ltmpl: Handle installing provides with filter_provides #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workaround for #1372 |
Pull Request Test Coverage Report for Build 7744828460Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
Ends up there's a function for all this! So now this mostly is just a pass-thru to dnf5, including the version comparisons. |
|
Unit tests passed, but didn't get reported for some reason. coverage change isn't a big deal. |
Previously the installpkg command used filter_match to select packages, which works great most of the time. It fails when the package is only available as a provide. This happened recently with wget moving to wget2-wget, causing builds to fail because it couldn't find wget. This changes installpkg to use the resolve_pkg_spec function, which as it happens also support globs and version comparison operators. DNF doesn't like the `==` operator, but I have retained support for it by translating it to a single `=`. I have dropped support for `=>` and `=<` since they are never used and are and odd way to specify `>=` and `>=` which of course still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using resolve_pkg_spec function.